Use type hints to further emphasize the custom serialization api#2116
Merged
mrocklin merged 1 commit intodask:masterfrom Jul 13, 2018
Merged
Use type hints to further emphasize the custom serialization api#2116mrocklin merged 1 commit intodask:masterfrom
mrocklin merged 1 commit intodask:masterfrom
Conversation
dhirschfeld
force-pushed
the
docs-for-dummies
branch
from
35c5676 to
8fc0f3f
Compare
Member
|
It's interesting to see types used in documentation like this. I wouldn't have thought of doing it myself. This looks good to me. Merging. (also, my apologies about the intermittent failures. I hope to find time to clean up that test soonish.) |
Contributor
Author
|
I think types, in documentation or otherwise can really help in understanding the intended api. It's something we've been using in our codebase since before mypy and we've found it pretty invaluable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.